Add data model suite #95
Conversation
tests/suites/data-model.js
Outdated
| 'start with the base-58-btc prefix (z), as defined in the ' + | ||
| 'Multibase section of Controller Documents 1.0. A ', |
There was a problem hiding this comment.
I'm not sure what should be written here. Maybe the A should just be dropped? Maybe 1.0.A was meant? For certain, the sentence should end with a ..
| 'start with the base-58-btc prefix (z), as defined in the ' + | |
| 'Multibase section of Controller Documents 1.0. A ', | |
| 'start with the base-58-btc prefix ("z"), as defined in the ' + | |
| 'Multibase section of Controller Documents 1.0.A.', |
There was a problem hiding this comment.
@TallTed this looks like a typo resulting from my cut and paste job. The line reads: "The publicKeyMultibase value of the verification method MUST start with the base-58-btc prefix (z), as defined in the Multibase section of Controller Documents 1.0" The A belongs to the next sentence: "A Multibase-encoded ECDSA 256-bit public key value or an ECDSA 384-bit public key value follows, as defined in the Multikey section of Controller Documents 1.0. Any other encoding MUST NOT be allowed."
So the A should be removed.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…eason. Co-authored-by: Ted Thibodeau Jr <[email protected]>
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
English looks OK. I don't speak JavaScript.
@TallTed you should learn. It's a great language. |
For various reasons, I prefer to keep English as my primary coding language, with which I achieve reasonably good results, even with my imperfect facility. |
Adds a bunch of issuer tests related to the Data Model section.